Need explanations about String substitution in Art of Fighting source code - Page 1

Hi,

I want to create a french translation for Art of Fighting. I'm able to build a new rom and run it in emulator.

But I have a problem, I simply thought I just had to replace english strings by french strings (with no accents or special chars, and with a limit of 32 characters length).
Unfortunately, it creates graphical glitchs or bugs (reboot).

Here an example which create a graphical glitch during a fight:

TO_VS_U: FIX_ADRS 4,14 FIX_DOUBLE 57H DC.B 'ACCUEILLEZ UN NOUVEAU CHALLEN',0FFH FIX_NEXT 0,1 FIX_DOUBLE 57H DC.B 'SCREEN SWITCHES TO VS MODE.',0FFH FIX_END
On my github :

What are the best practices ?
Should I change another variable somewhere else ?

Thank you

Pics / ROM on it didn't happen.

Okay, here a video



I've just replaced :

DC.B 'HERE COMES A CHALLENGER. THE',0FFH
By
DC.B 'ACCUEILLEZ UN NOUVEAU CHALLENG',0FFH
You'll see the glitch when fight begin, top right corner.
If I remove one char => CHALLEN instead of CHALLENG, everything works fine.
Rom is available here.

Thank you !

Ah, so the issue is on an unrelated message.

Probably changing string length ends up shifting some data elsewhere

Need to check out how the thing is compiled.

OK, here's a workaround by relocating messages data:

- Compile LANG file with 0x80000 base address
- Append it to the original 044-p1.bin file, expanding rom to 1MB
- patch 0x00080000 @ 0x3d7be

http://dl.free.fr/getfile.pl?file=/4Ts45RGq

Because ASM68K is not my favorite platform, I don't understand what I should do.

Here how I compile LANG:

asm68k -I ../inc LANG2.SRC asm68k -I ../inc LANG3.SRC lnk68k -c LANG.CMD -m > LANG.MAP copy *.abs ..\\bin n how I create OUT file

iee2aout LANG.ABS LANG.OUT
Then how I create the rom

del 044-p1.p1 del rom.bin ..\..\rom_add\Release\rom_add rom.bin 0x80000 GAME.OUT 0x0 ..\..\rom_add\Release\rom_add rom.bin 0x80000 SYS.OUT 0xa00 0x11600 ..\..\rom_add\Release\rom_add rom.bin 0x80000 SYS_DATA.BIN 0x4f40 ..\..\rom_add\Release\rom_add rom.bin 0x80000 HERO.OUT 0x12000 0x7000 ..\..\rom_add\Release\rom_add rom.bin 0x80000 HK3.OUT 0x19000 0xD000 ..\..\rom_add\Release\rom_add rom.bin 0x80000 CHARA.OUT 0x26000 0x17800 ..\..\rom_add\Release\rom_add rom.bin 0x80000 DEMO_DATA.bin 0x3AA90 ..\..\rom_add\Release\rom_add rom.bin 0x80000 LANG.OUT 0x3d800 ..\..\rom_add\Release\rom_add rom.bin 0x80000 OTHER_DATA.bin 0x42b00 byteswap.exe rom.bin ren rom.bin 044-p1.p1
What should I change in my toolchain ?

- Compile LANG file with 0x80000 base address
- Append it to the original 044-p1.bin file, expanding rom to 1MB
- patch 0x00080000 @ 0x3d7be